Summary

Always use absolute URLs for image diff review thumbnails

Review Request #8390 — Created Sept. 8, 2016 and submitted Sept. 19, 2016, 4:16 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Previously, only single image (or the latest image in a image diff) were
using absolute URLs in thumbnails, which would result in them not being
renderable in e-mails. This patch addresses the issue.

Testing Done


Ran unit tests.
Checked the generated HTML and saw that an absolute URL was used.

Issues

Description	From	Last Updated
Can you add a unit test for this?	chipx86	Sept. 15, 2016, 4:29 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/ui/image.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/ui/image.py

The issue has been resolved. Show all issues
```
Can you add a unit test for this?
```

Change Summary:

added unit tests

Diff:

Revision 2 (+77)

Show changes

	reviewboard/reviews/ui/image.py
	reviewboard/reviews/ui/tests.py
	reviewboard/testing/testcase.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/reviews/ui/image.py
    reviewboard/reviews/ui/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/reviews/ui/image.py
    reviewboard/reviews/ui/tests.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (68cee6a)