Remove a trailing comma in the JavaScript for the dashboard page.

Review Request #8381 — Created Sept. 5, 2016 and submitted

Information

Review Board
release-2.5.x
12abb19...

Reviewers

The dashboard sets up some JavaScript to govern the functionality of the
page, but for non-Local Sites it ends up with a trailing comma, which
could break some browsers.

This change switches the order of attributes passed to RB.Dashboard,
preventing the trailing comma issue from occurring.

Checked the Dashboard page and source for the global and local sites, and
saw that the pages both worked and didn't have trailing commas.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/datagrids/datagrid.html
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/datagrids/datagrid.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (fd12437)
Loading...