Provide organization to the authentication settings forms.

Review Request #8378 — Created Sept. 3, 2016 and submitted

Information

Review Board
release-2.0.x
5bfac68...

Reviewers

The authentication settings forms have always just been a flat list of
fields, without any real organization and, in some cases, no sane order.
That made some settings forms, like for LDAP, a bit confusing.

This change adds support for fieldsets for auth forms, and makes use of
them for Active Directory, Standard Auth, and LDAP.

Visually and functionally tested each form. Counted the fields to make
sure that nothing went missing.


reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    Ignored Files:
        reviewboard/templates/admin/authentication_settings.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    Ignored Files:
        reviewboard/templates/admin/authentication_settings.html
    
    
  2. 
      
david
  1. 
      
  2. Does this field get hidden or disabled when "Find DC from DNS" is selected?

    1. No, there's no intelligence for these forms. That'd be a whole other body of work.

  3. 
      
david
  1. Ship It!
  2. 
      
chipx86
chipx86
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (f18cc52)
Loading...