Add a new integration for Slack.
Review Request #8372 — Created Aug. 31, 2016 and submitted
This adds a new Review Board 3.0-compatible integration for Slack. This is built upon the original rbslack extension, but enhances the message sent to Slack to include additional information, such as the first file attachment on a review request (or newest one on an update), the description on a review request, change description on updates, body_top/first comment text on reviews/replies, trophies, and more. This new integration takes advantage of the new conditions support in Review Board 3.0 to allow admins to create multiple custom Slack configurations, meaning that one server can post to different Slack channels or even Slack teams, depending on whatever criteria they choose. Unit tests were added that cover all the ways we might send a message, ensuring we won't unexpectedly break as things evolve.
Unit tests pass.
Tested every type of message manually.
| Description | From | Last Updated |
|---|---|---|
|
I know this isn't part of this patch, but there's a typo here - "serivce" -> "service". |
 mike_conley
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
 reviewbot
|
|
|
Docstring. |
 brennie
|
|
|
This can be a tuple. |
brennie
|
|
|
The title should be localized. |
 david
|
|
|
The title should be localized. |
david
|
|
|
Needs a trailing comma |
david
|
|
|
Mark for localization? |
david
|
-
-
rbintegrations/extension.py (Diff revision 1) I know this isn't part of this patch, but there's a typo here - "serivce" -> "service".
Change Summary:
- Fixed a typo in
setup.py. - Fixed a long line length issue.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+2378 -1) |
-
Tool: Pyflakes Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png Tool: PEP8 Style Checker Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png
-
-
rbintegrations/extension.py (Diff revision 2) Shouldnt this have been an add? did it get added mistakenly beforehand?
-
-
Change Summary:
- Added a missing docstring.
- Converted a list to a tuple.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+2384 -1) |
-
Tool: Pyflakes Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png Tool: PEP8 Style Checker Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png
Change Summary:
- Changed some fieldset titles to Title Case, and changed the wording.
- Added a missing trailing comma.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+2384 -1) |
-
Tool: Pyflakes Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png Tool: PEP8 Style Checker Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png
Tool: Pyflakes Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png Tool: PEP8 Style Checker Processed Files: rbintegrations/slack/tests.py rbintegrations/extension.py rbintegrations/testing/testcases.py rbintegrations/slack/forms.py rbintegrations/slack/integration.py Ignored Files: rbintegrations/static/images/slack/icon@2x.png rbintegrations/testing/__init__.py rbintegrations/slack/__init__.py rbintegrations/static/images/slack/icon.png