Summary

Add a new integration for Slack.

Review Request #8372 — Created Aug. 31, 2016 and submitted Sept. 27, 2016, 11:20 p.m.

Information

Owner

chipx86

Repository

rbintegrations

Branch

master

Bugs

Depends On

Commit

6817a6b...

Reviewers

Groups

rbintegrations

People

Description

This adds a new Review Board 3.0-compatible integration for Slack. This
is built upon the original rbslack extension, but enhances the message
sent to Slack to include additional information, such as the first file
attachment on a review request (or newest one on an update), the
description on a review request, change description on updates,
body_top/first comment text on reviews/replies, trophies, and more.

This new integration takes advantage of the new conditions support in
Review Board 3.0 to allow admins to create multiple custom Slack
configurations, meaning that one server can post to different Slack
channels or even Slack teams, depending on whatever criteria they
choose.

Unit tests were added that cover all the ways we might send a message,
ensuring we won't unexpectedly break as things evolve.

Testing Done

Unit tests pass.

Tested every type of message manually.

Files

Issues

Description	From	Last Updated
I know this isn't part of this patch, but there's a typo here - "serivce" -> "service".	mike_conley	Aug. 31, 2016, 11:27 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 31, 2016, 11:28 p.m.
Docstring.	brennie	Sept. 19, 2016, 4:07 p.m.
This can be a tuple.	brennie	Sept. 19, 2016, 4:08 p.m.
The title should be localized.	david	Sept. 26, 2016, 3:30 p.m.
The title should be localized.	david	Sept. 26, 2016, 3:30 p.m.
Needs a trailing comma	david	Sept. 26, 2016, 3:30 p.m.
Mark for localization?	david	Sept. 27, 2016, 11:20 p.m.

Tool: Pyflakes
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png



Tool: PEP8 Style Checker
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png

rbintegrations/slack/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

rbintegrations/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I know this isn't part of this patch, but there's a typo here - "serivce" -> "service".
```
1. chipx86 Aug. 31, 2016, 11:28 p.m.
  Good eye :)

Change Summary:


Fixed a typo in setup.py.
Fixed a long line length issue.

Commit:

938ba980a8a2312af8108dc066f2e0e4a90f6011

c13021c4692da505a81b217445cb3d022d000db0

Diff:

Revision 2 (+2378 -1)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/__init__.py
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/tests.py
	rbintegrations/static/images/slack/icon.png
	rbintegrations/static/images/slack/icon@2x.png
	rbintegrations/testing/__init__.py
	1 more

Tool: Pyflakes
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png



Tool: PEP8 Style Checker
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png

rbintegrations/extension.py (Diff revision 2)

Shouldnt this have been an add? did it get added mistakenly beforehand?

chipx86 Sept. 19, 2016, 4:06 p.m.
```
Yep.
```

rbintegrations/slack/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Docstring.
```
rbintegrations/slack/integration.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This can be a tuple.
```

Change Summary:


Added a missing docstring.
Converted a list to a tuple.

Commit:

c13021c4692da505a81b217445cb3d022d000db0

46a2438a286f40c88c3b1a55e2dc965420e5c0d8

Diff:

Revision 3 (+2384 -1)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/__init__.py
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/tests.py
	rbintegrations/static/images/slack/icon.png
	rbintegrations/static/images/slack/icon@2x.png
	rbintegrations/testing/__init__.py
	1 more

Tool: Pyflakes
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png



Tool: PEP8 Style Checker
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png

rbintegrations/slack/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
The title should be localized.
```
rbintegrations/slack/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
The title should be localized.
```
rbintegrations/slack/integration.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Needs a trailing comma
```

Change Summary:


Changed some fieldset titles to Title Case, and changed the wording.
Added a missing trailing comma.

Commit:

46a2438a286f40c88c3b1a55e2dc965420e5c0d8

6817a6bd158b6716aa5c3a6e2a629d75c6eb2d9f

Diff:

Revision 4 (+2384 -1)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/__init__.py
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/tests.py
	rbintegrations/static/images/slack/icon.png
	rbintegrations/static/images/slack/icon@2x.png
	rbintegrations/testing/__init__.py
	1 more

Tool: Pyflakes
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png



Tool: PEP8 Style Checker
Processed Files:
    rbintegrations/slack/tests.py
    rbintegrations/extension.py
    rbintegrations/testing/testcases.py
    rbintegrations/slack/forms.py
    rbintegrations/slack/integration.py

Ignored Files:
    rbintegrations/static/images/slack/icon@2x.png
    rbintegrations/testing/__init__.py
    rbintegrations/slack/__init__.py
    rbintegrations/static/images/slack/icon.png

Ship it!

rbintegrations/extension.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Mark for localization?
```

Status:: Completed
Change Summary:: Pushed to master (c463b43)