Summary

Plumb options for diff viewer page.

Review Request #8368 — Created Aug. 30, 2016 and submitted Aug. 31, 2016, 10:03 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

6306f2d...

Reviewers

Groups

reviewboard

People

Description

Recent refactoring required options to be plumbed explicitly. This was
neglected for the DiffViewerPageView, breaking loading of diffs.

Testing Done

Loaded the diffviewer and saw it work.

Expand All
Collapse All

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Ship it!

Looks good. Does this also need to be done for review UI pages?

david Aug. 31, 2016, 10:03 a.m.

Just tested a review UI and it looks like it works.

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (c7b95d7)