Make `rbt install` work correctly on Windows.

Review Request #8354 — Created Aug. 26, 2016 and submitted

Information

RBTools
release-0.7.x
19f4dd7...

Reviewers

Unfortunately, the technique of using NamedTemporaryFile in a context manager
and yielding the filename back, then reopening it from elsewhere in the code
caused various permission errors when running on Windows.

This change rearranges the code a bit to make sure we flush and close the file,
and then handles cleanup ourselves.

Used it on OS X, and a customer reports success running on Windows.

Description From Last Updated

'contextmanager' imported but unused

reviewbotreviewbot

Should we have these in a finally block?

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/install.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/commands/install.py
    
    
  2. rbtools/commands/install.py (Diff revision 1)
     
     
     'contextmanager' imported but unused
    
  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/install.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/install.py
    
    
  2. 
      
brennie
  1. 
      
  2. rbtools/commands/install.py (Diff revision 2)
     
     
     

    Should we have these in a finally block?

  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/install.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/install.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (aab2bb9)
Loading...