Summary

Make `rbt install` work correctly on Windows.

Review Request #8354 — Created Aug. 26, 2016 and submitted Aug. 29, 2016, 3:37 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

19f4dd7...

Reviewers

Groups

rbtools

People

Description

Unfortunately, the technique of using NamedTemporaryFile in a context manager
and yielding the filename back, then reopening it from elsewhere in the code
caused various permission errors when running on Windows.

This change rearranges the code a bit to make sure we flush and close the file,
and then handles cleanup ourselves.

Testing Done

Used it on OS X, and a customer reports success running on Windows.

Issues

Description	From	Last Updated
'contextmanager' imported but unused	reviewbot	Aug. 26, 2016, 11:53 a.m.
Should we have these in a finally block?	brennie	Aug. 26, 2016, 4:09 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/install.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/install.py

rbtools/commands/install.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'contextmanager' imported but unused
```

Commit:

b545422818fffa33cbdbb36708e5b689c66f26c8

43c524d6cda4517c984014a159f6e81c06753d9a

Diff:

Revision 2 (+24 -17)

Show changes

rbtools/commands/install.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/install.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/install.py

rbtools/commands/install.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Should we have these in a finally block?
```

Commit:

43c524d6cda4517c984014a159f6e81c06753d9a

19f4dd79fff80afc2ae139cfb7016b22eca32200

Diff:

Revision 3 (+17 -11)

Show changes

rbtools/commands/install.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/install.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/install.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (aab2bb9)

rbtools/commands/install.py (Diff revision 1)

rbtools/commands/install.py (Diff revision 2)