Add condition operators for working with regexes.

Review Request #8346 — Created Aug. 25, 2016 and submitted

Information

Djblets
release-0.10.x
59e5798...

Reviewers

This introduces two new operators for matching or not matching against a
user-provided regex. The regex is checked for validity and stored as a
serialized pattern in the condition, and then used to match the given
string during the condition matching process.

BaseConditionStringChoice now includes these by default. It also adds
the "Does Not Contain" operator, which was missing before.

Unit tests pass.

Description From Last Updated

're' imported but unused

reviewbotreviewbot

'six' imported but unused

reviewbotreviewbot

This really doesn't add anything to the summary.

daviddavid

Same here.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/conditions/values.py
        djblets/conditions/operators.py
        djblets/conditions/choices.py
        djblets/conditions/tests/test_values.py
        djblets/conditions/tests/test_operators.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/conditions/values.py
        djblets/conditions/operators.py
        djblets/conditions/choices.py
        djblets/conditions/tests/test_values.py
        djblets/conditions/tests/test_operators.py
    
    
  2. djblets/conditions/operators.py (Diff revision 1)
     
     
     're' imported but unused
    
  3. djblets/conditions/tests/test_values.py (Diff revision 1)
     
     
     'six' imported but unused
    
  4. 
      
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/conditions/values.py
        djblets/conditions/operators.py
        djblets/conditions/choices.py
        djblets/conditions/tests/test_values.py
        djblets/conditions/tests/test_operators.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/conditions/values.py
        djblets/conditions/operators.py
        djblets/conditions/choices.py
        djblets/conditions/tests/test_values.py
        djblets/conditions/tests/test_operators.py
    
    
  2. 
      
david
  1. 
      
  2. djblets/conditions/operators.py (Diff revision 2)
     
     

    This really doesn't add anything to the summary.

  3. djblets/conditions/operators.py (Diff revision 2)
     
     

    Same here.

  4. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/conditions/values.py
        djblets/conditions/operators.py
        djblets/conditions/choices.py
        djblets/conditions/tests/test_values.py
        djblets/conditions/tests/test_operators.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/conditions/values.py
        djblets/conditions/operators.py
        djblets/conditions/choices.py
        djblets/conditions/tests/test_values.py
        djblets/conditions/tests/test_operators.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (71b0f80)
Loading...