Summary

Add condition operators for working with regexes.

Review Request #8346 — Created Aug. 25, 2016 and submitted Aug. 29, 2016, 1:50 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Commit

59e5798...

Reviewers

Groups

djblets

People

Description

This introduces two new operators for matching or not matching against a
user-provided regex. The regex is checked for validity and stored as a
serialized pattern in the condition, and then used to match the given
string during the condition matching process.

BaseConditionStringChoice now includes these by default. It also adds
the "Does Not Contain" operator, which was missing before.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
're' imported but unused	reviewbot	Aug. 25, 2016, 4:06 p.m.
'six' imported but unused	reviewbot	Aug. 25, 2016, 4:06 p.m.
This really doesn't add anything to the summary.	david	Aug. 29, 2016, 12:45 p.m.
Same here.	david	Aug. 29, 2016, 12:45 p.m.

Tool: Pyflakes
Processed Files:
    djblets/conditions/values.py
    djblets/conditions/operators.py
    djblets/conditions/choices.py
    djblets/conditions/tests/test_values.py
    djblets/conditions/tests/test_operators.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/conditions/values.py
    djblets/conditions/operators.py
    djblets/conditions/choices.py
    djblets/conditions/tests/test_values.py
    djblets/conditions/tests/test_operators.py

djblets/conditions/operators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 're' imported but unused
```
djblets/conditions/tests/test_values.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'six' imported but unused
```

Change Summary:

Removed unused imports.

Commit:

-	9b3bfdad39195ac265bdbdb5afe5325f6156f148
+	ea69d0868252ff51ec4e5a4fd5360d20b3c139bb

Diff:

Revision 2 (+199 -1)

Show changes

	djblets/conditions/choices.py
	djblets/conditions/operators.py
	djblets/conditions/values.py
	djblets/conditions/tests/test_operators.py
	djblets/conditions/tests/test_values.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/conditions/values.py
    djblets/conditions/operators.py
    djblets/conditions/choices.py
    djblets/conditions/tests/test_values.py
    djblets/conditions/tests/test_operators.py



Tool: Pyflakes
Processed Files:
    djblets/conditions/values.py
    djblets/conditions/operators.py
    djblets/conditions/choices.py
    djblets/conditions/tests/test_values.py
    djblets/conditions/tests/test_operators.py

djblets/conditions/operators.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This really doesn't add anything to the summary.
```
djblets/conditions/operators.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same here.
```

Change Summary:

Removed some redundant text that were in the docstrings redundantly.

Commit:

-	ea69d0868252ff51ec4e5a4fd5360d20b3c139bb
+	59e579881e80441ac3fd0bd16aaf18e5684a48c5

Diff:

Revision 3 (+195 -1)

Show changes

	djblets/conditions/choices.py
	djblets/conditions/operators.py
	djblets/conditions/values.py
	djblets/conditions/tests/test_operators.py
	djblets/conditions/tests/test_values.py

Tool: Pyflakes
Processed Files:
    djblets/conditions/values.py
    djblets/conditions/operators.py
    djblets/conditions/choices.py
    djblets/conditions/tests/test_values.py
    djblets/conditions/tests/test_operators.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/conditions/values.py
    djblets/conditions/operators.py
    djblets/conditions/choices.py
    djblets/conditions/tests/test_values.py
    djblets/conditions/tests/test_operators.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (71b0f80)