Update the conditions match calls to always use keyword arguments.
Review Request #8345 — Created Aug. 25, 2016 and submitted
| Information | |
|---|---|
| chipx86 | |
| Djblets | |
| release-0.10.x | |
| 59b11ca... | |
| Reviewers | |
| djblets | |
BaseConditionOperator.matches()is now called using keyword arguments.
This makes it easier for those methods that don't want to take certain
arguments to simply hide them in their**kwargs, simplifying some
implementations/docs and helping keep function signatures consistent.
Unit tests pass.
Change Summary:
Removed the keyword argument usage for
get_match_value()'svalueargument, to allow implementations to
use something more meaningful in their implementation.
Summary: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||
Commit: |
|
||||||||||||||||||
Diff: |
Revision 2 (+10 -14) |
-
Tool: Pyflakes Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py Tool: PEP8 Style Checker Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py
Tool: Pyflakes Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py Tool: PEP8 Style Checker Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py