Update the conditions match calls to always use keyword arguments.
Review Request #8345 — Created Aug. 25, 2016 and submitted
BaseConditionOperator.matches()is now called using keyword arguments.
This makes it easier for those methods that don't want to take certain
arguments to simply hide them in their**kwargs, simplifying some
implementations/docs and helping keep function signatures consistent.
Unit tests pass.
- Change Summary:
-
Removed the keyword argument usage for
get_match_value()'svalueargument, to allow implementations to
use something more meaningful in their implementation. - Summary:
-
Update the conditions match/lookup calls to always use keyword arguments.Update the conditions match calls to always use keyword arguments.
- Description:
-
~ BaseConditionChoice.get_match_value()and~ BaseConditionOperator.matches()is now called using keyword arguments.- BaseConditionOperator.matches()are now called using keyword arguments.This makes it easier for those methods that don't want to take certain arguments to simply hide them in their **kwargs, simplifying someimplementations/docs and helping keep function signatures consistent. - Commit:
-
a179320344ed02eb9af953d077ee7eb38c4cd2d759b11ca762aaf90d769ff793e119797c81cf54c9
-
Tool: Pyflakes Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py Tool: PEP8 Style Checker Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py
Tool: Pyflakes Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py Tool: PEP8 Style Checker Processed Files: djblets/conditions/tests/test_operators.py djblets/conditions/conditions.py djblets/conditions/tests/test_conditions.py djblets/conditions/operators.py