Small improvements to the review CSS.

Review Request #8341 — Created Aug. 22, 2016 and submitted

Information

Review Board
release-3.0.x
2adcd3f...

Reviewers

This change makes a few small improvements to the look of the review detail
generally (and review boxes in particular). I'm planning on doing a somewhat
more invasive clean-up like I did to the review request box, but that will come
later.

The changes herein are:

  • Removal of the 0.5em margin around the review/changedesc boxes, which was so
    small as to be unnoticable (except when I added another full-width box that
    didn't match the width of the review request box).
  • Cleanup of the bottom margin of the page to avoid extra space.
  • Tweaking of margins and padding to make it so the expand/collapse buttons had
    the same amount of spacing on both review and changedesc boxes.
  • Tweaking of spacing for collapsed boxes so that there wasn't any extra height
    that didn't need to be there.

Looked at the page in both desktop and mobile mode. Checked that everything
changed looked correct.


reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
chipx86
  1. Can you post a non-Retina screenshot? It's really hard to see the differences with it the way it is.

    1. Or you could deploy the latest release-3.0.x and get image zooming awesomeness :)

  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (0d66e42)
Loading...