Handle HostingServiceErrors in the the repo branch resource

Review Request #8340 — Created Aug. 19, 2016 and submitted

Information

Review Board
release-2.0.x
04a3dc9...

Reviewers

Previously, if there was an error talking to the hosting service while
fetching the branches we would not handle the error and the user would
only see that a HTTP 500 error. We now present catch this error and
present it to the user.

Faked an API error in GitHub.get_branches with and without this
patch applied. Without the patch applied a 500 error was shown. With
this patch, the error message was shown.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/repository_branches.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/repository_branches.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (78df762)
Loading...