chipx86 got a fish trophy!
Add condition choices/operators for review requests, repositories, and more.
Review Request #8338 — Created Aug. 29, 2016 and submitted
This introduces a new set of standardized condition choices and operators for any extensions, integrations, or built-in UI that wants to offer user-customizable condition sets based on review requests, repositories, or review groups. The repository-based condition choices/operators allow for matching repositories based on the SCMTool type, the public/privacy level, set/unset state, or by comparing to a list of user-defined repository entries. The review group condition choices/operators allow for matching a list/queryset of review groups based on the invite-only flags, empty/non-empty states, or by comparing to a list of user-defined review group entries. The review request condition choices/operators build upon both of these, offering those choices in relation to the review request's target group list and associated repository. It also includes operators for built-in fields and for matching modified files in the current diff. Unit tests were added that cover everything but the most trivial choices (those that are simply based on already-tested choice classes in Djblets).
Unit tests pass.
Made use of these in an integration. From current testing, they work
as expected (though more thorough testing will be needed for corner
cases).
| Description | From | Last Updated |
|---|---|---|
|
Col: 80 E501 line too long (80 > 79 characters) |
 reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
'Tool' imported but unused |
reviewbot
|
|
|
Was this intended to be "Are all"? |
 david
|
|
|
The label on the field has a capital "Done" |
david
|
- Change Summary:
-
Fixed line length and unused import errors.
- Commit:
-
2cb2306d3eb7d3fc6c50a79543b83ae9221cfd1c1beafe3c54da5751e42481f64ae0583b7e75b713
-
Tool: Pyflakes Processed Files: reviewboard/site/conditions.py reviewboard/scmtools/conditions.py reviewboard/reviews/tests/test_conditions.py reviewboard/scmtools/tests/test_conditions.py reviewboard/reviews/conditions.py Tool: PEP8 Style Checker Processed Files: reviewboard/site/conditions.py reviewboard/scmtools/conditions.py reviewboard/reviews/tests/test_conditions.py reviewboard/scmtools/tests/test_conditions.py reviewboard/reviews/conditions.py
- Change Summary:
-
- Fixed a typo in one of the operator names.
- Changed "Testing done" to "Testing Done".
- Commit:
-
1beafe3c54da5751e42481f64ae0583b7e75b71391a96cfbf81f6eb6f657e741bee1ed5d61acb7d9
-
Tool: Pyflakes Processed Files: reviewboard/site/conditions.py reviewboard/scmtools/conditions.py reviewboard/reviews/tests/test_conditions.py reviewboard/scmtools/tests/test_conditions.py reviewboard/reviews/conditions.py Tool: PEP8 Style Checker Processed Files: reviewboard/site/conditions.py reviewboard/scmtools/conditions.py reviewboard/reviews/tests/test_conditions.py reviewboard/scmtools/tests/test_conditions.py reviewboard/reviews/conditions.py
Tool: Pyflakes Processed Files: reviewboard/site/conditions.py reviewboard/scmtools/conditions.py reviewboard/reviews/tests/test_conditions.py reviewboard/scmtools/tests/test_conditions.py reviewboard/reviews/conditions.py Tool: PEP8 Style Checker Processed Files: reviewboard/site/conditions.py reviewboard/scmtools/conditions.py reviewboard/reviews/tests/test_conditions.py reviewboard/scmtools/tests/test_conditions.py reviewboard/reviews/conditions.py