Show non-field errors in the siteconfig settings form

Review Request #8329 — Created Aug. 15, 2016 and submitted

Information

Djblets
release-0.9.x
cdda8f4...

Reviewers

The Djblets siteconfig settings form did not show non-field errors.
This patch addresses that.

Tested this with Review Board.

Description From Last Updated

Your description still talks about __all__

daviddavid

Oh, typo in your description: "siteconfiig"

daviddavid

How does this differ from {{ form.non_field_errors }} ?

daviddavid

Typo: formn You probably also don't need the conditional at all.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        djblets/siteconfig/templates/siteconfig/settings.html
    
    
    
    Tool: Pyflakes
    Ignored Files:
        djblets/siteconfig/templates/siteconfig/settings.html
    
    
  2. 
      
brennie
david
  1. 
      
  2. Show all issues

    How does this differ from {{ form.non_field_errors }} ?

    1. It doesn't. I didn't know that was a thing.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        djblets/siteconfig/templates/siteconfig/settings.html
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        djblets/siteconfig/templates/siteconfig/settings.html
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    Your description still talks about __all__

  3. Show all issues

    Typo: formn

    You probably also don't need the conditional at all.

  4. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        djblets/siteconfig/templates/siteconfig/settings.html
    
    
    
    Tool: Pyflakes
    Ignored Files:
        djblets/siteconfig/templates/siteconfig/settings.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
david
  1. 
      
  2. Show all issues

    Oh, typo in your description: "siteconfiig"

  3. 
      
brennie
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.9.x (964cf7c)