Summary

Show non-field errors in the siteconfig settings form

Review Request #8329 — Created Aug. 15, 2016 and submitted Aug. 18, 2016, 9:30 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Blocks

8330

Commit

cdda8f4...

Reviewers

Groups

djblets

People

Description

The Djblets siteconfig settings form did not show non-field errors.
This patch addresses that.

Testing Done

Tested this with Review Board.

Issues

Description	From	Last Updated
Your description still talks about __all__	david	Aug. 18, 2016, 4:12 p.m.
Oh, typo in your description: "siteconfiig"	david	Aug. 18, 2016, 9:27 p.m.
How does this differ from {{ form.non_field_errors }} ?	david	Aug. 16, 2016, 5:16 p.m.
Typo: formn You probably also don't need the conditional at all.	david	Aug. 18, 2016, 4:14 p.m.

Tool: PEP8 Style Checker
Ignored Files:
    djblets/siteconfig/templates/siteconfig/settings.html



Tool: Pyflakes
Ignored Files:
    djblets/siteconfig/templates/siteconfig/settings.html

Testing Done:: ~
Tested this with Review Board (see
~
Tested this with Review Board.
- https://reviews.reviewboard.org/r/8330/)

djblets/siteconfig/templates/siteconfig/settings.html (Diff revision 1)
The issue has been resolved. Show all issues
```
How does this differ from {{ form.non_field_errors }} ?
```
1. brennie Aug. 16, 2016, 5:15 p.m.
  It doesn't. I didn't know that was a thing.

Summary:

Show errors in the siteconfig settings form

Show non-field errors in the siteconfig settings form

Commit:

523a9b093df88bf9494a49435ff87e57489a3c60

8e99e32360e137ad3d0e8dfa727a0116f9c23ad6

Diff:

Revision 2 (+3)

Show changes

djblets/siteconfig/templates/siteconfig/settings.html

Tool: Pyflakes
Ignored Files:
    djblets/siteconfig/templates/siteconfig/settings.html



Tool: PEP8 Style Checker
Ignored Files:
    djblets/siteconfig/templates/siteconfig/settings.html

The issue has been resolved. Show all issues

Your description still talks about __all__

djblets/siteconfig/templates/siteconfig/settings.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo: formn
You probably also don't need the conditional at all.
```

Description:

~		The Djblets siteconfiig settings form did not show global errors (tagged
~		under the `__all__` field). This patch addresses that.
	~	The Djblets siteconfiig settings form did not show non-field errors.
	~	This patch addresses that.

Commit:

8e99e32360e137ad3d0e8dfa727a0116f9c23ad6

cdda8f40b9500fb075a8fa8d952cdf4dc9d43791

Diff:

Revision 3 (+1)

Show changes

djblets/siteconfig/templates/siteconfig/settings.html

Tool: PEP8 Style Checker
Ignored Files:
    djblets/siteconfig/templates/siteconfig/settings.html



Tool: Pyflakes
Ignored Files:
    djblets/siteconfig/templates/siteconfig/settings.html

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Oh, typo in your description: "siteconfiig"

Description:: ~
The Djblets siteconfiig settings form did not show non-field errors.
~
The Djblets siteconfig settings form did not show non-field errors.
This patch addresses that.

Status:: Completed
Change Summary:: Pushed to release-0.9.x (964cf7c)

~		Tested this with Review Board (see
	~	Tested this with Review Board.
-		https://reviews.reviewboard.org/r/8330/)