Refactor away ReviewBoxListView.
Review Request #8318 — Created Aug. 4, 2016 and submitted
This change makes it so that instead of
ReviewBoxListViewinspecting the DOM
and creating models and views to go along with it, those models and views are
created directly with the appropriate data. After this,ReviewBoxListViewwas
pretty useless, and becauseReviewRequestPageViewalready had its fingers in
the pie, I've just moved all its functionality into there.
- Ran js-tests.
- Smoke tested the review request detail page with multiple reviews and change
description boxes.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+264 -332) |
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/pages/views/tests/reviewRequestPageViewTests.es6.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/templates/reviews/review_detail.html reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js reviewboard/templates/reviews/boxes/change.html reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/pages/views/tests/reviewRequestPageViewTests.es6.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/templates/reviews/review_detail.html reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js reviewboard/templates/reviews/boxes/change.html reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js
-
-
reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js (Diff revision 2) Are these not under
this.el? Can we not usethis.$()?
-
Happy after this and Barret's comment.
-
reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js (Diff revision 2) Let's use
listenTo.
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/pages/views/tests/reviewRequestPageViewTests.es6.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/templates/reviews/review_detail.html reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js reviewboard/templates/reviews/boxes/change.html reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/pages/views/tests/reviewRequestPageViewTests.es6.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/templates/reviews/review_detail.html reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js reviewboard/templates/reviews/boxes/change.html reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js