Port various review request detail JS files to ES6.
Review Request #8316 — Created Aug. 2, 2016 and submitted
This change ports over several of the pieces of the review request detail page,
including the page view itself, and the review and changedesc box views. This
is in preparation for some refactoring to make the creation and plumbing of all
of these boxes much simpler.
- Smoke tested a page with multiple review and changedesc boxes.
- Ran js-tests.
| Description | From | Last Updated |
|---|---|---|
|
Can we make this a const in the file and wrap everything in a block so we don't re-define this … |
brennie
|
|
|
initialize(options) |
brennie
|
|
|
render() |
brennie
|
|
|
Should we use listenTo? |
chipx86
|
|
|
Why the payload change? The original seemed fine, and this doesn't seem too related to the change. |
chipx86
|
|
|
We probably should update this to use listenTo. |
chipx86
|
-
This would be a lot easier to review if you can convince git that the files are moved. Could play more with the
-Margument to git diff for this. (Annoying for the posting, but would be really nice to help see what changed.)
Review request changed
- Change Summary:
-
Diff with better move detection.
- Diff:
-
Revision 2 (+442 -319)
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/collapsableBoxView.es6.js reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/reviewBoxView.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/collapsableBoxView.es6.js reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/reviewBoxView.es6.js
Review request changed
- Change Summary:
-
Use
listenTo - Commit:
-
b14e181c57a6ab7ec5a57c299f3c8c4c1e07117451b52cbef5bacf62feedeab34ecb2e86ef62a87d
- Diff:
-
Revision 3 (+443 -319)
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/collapsableBoxView.es6.js reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/reviewBoxView.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/collapsableBoxView.es6.js reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/reviewBoxView.es6.js
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.js reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/collapsableBoxView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.js reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/changeBoxView.js reviewboard/static/rb/js/views/reviewBoxView.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.js reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/collapsableBoxView.es6.js reviewboard/static/rb/js/views/reviewBoxListView.js reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/changeBoxView.js reviewboard/static/rb/js/views/reviewBoxView.es6.js