Improve the look of commit history diffs

Review Request #8315 — Created July 28, 2016 and submitted

Information

Review Board
dvcs

Reviewers

Diffs between two commit histories are now much more easy to visualize.
Since we have information about how commit histories have changed from
RBTools, we can better determine if commits are modified, unmodified, or
re-ordered. This allows for a much better user experience.

NB: This currently only affects the look and feel of the commit history
diff in change descriptions. The diffviewer will be updated in a future
patch.

Ran unit tests.


Description From Last Updated

Can we use our existing diff colors for this?

daviddavid

'CommitHistoryDiffEntry' imported but unused

reviewbotreviewbot

Trailing whitespace.

daviddavid

typo: "typeS"

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/commitutils.py
    
    Ignored Files:
        reviewboard/static/rb/images/commit_path_bg.png
        reviewboard/static/rb/css/pages/diffviewer.less
        reviewboard/templates/reviews/boxes/commit_list.html
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/templates/reviews/boxes/commit_list_change.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/commitutils.py
    
    Ignored Files:
        reviewboard/static/rb/images/commit_path_bg.png
        reviewboard/static/rb/css/pages/diffviewer.less
        reviewboard/templates/reviews/boxes/commit_list.html
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/templates/reviews/boxes/commit_list_change.html
    
    
  2. reviewboard/diffviewer/views.py (Diff revision 1)
     
     
    Show all issues
     'CommitHistoryDiffEntry' imported but unused
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/commitutils.py
    
    Ignored Files:
        reviewboard/static/rb/images/commit_path_bg.png
        reviewboard/static/rb/css/pages/diffviewer.less
        reviewboard/templates/reviews/boxes/commit_list.html
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/templates/reviews/boxes/commit_list_change.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/commitutils.py
    
    Ignored Files:
        reviewboard/static/rb/images/commit_path_bg.png
        reviewboard/static/rb/css/pages/diffviewer.less
        reviewboard/templates/reviews/boxes/commit_list.html
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/templates/reviews/boxes/commit_list_change.html
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    Can we use our existing diff colors for this?

  3. Show all issues

    Trailing whitespace.

  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/commitutils.py
    
    Ignored Files:
        reviewboard/static/rb/images/commit_path_bg.png
        reviewboard/static/rb/css/pages/diffviewer.less
        reviewboard/templates/reviews/boxes/commit_list.html
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/templates/reviews/boxes/commit_list_change.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/diffviewer/views.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/commitutils.py
    
    Ignored Files:
        reviewboard/static/rb/images/commit_path_bg.png
        reviewboard/static/rb/css/pages/diffviewer.less
        reviewboard/templates/reviews/boxes/commit_list.html
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/templates/reviews/boxes/commit_list_change.html
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/diffviewer/commitutils.py (Diff revision 3)
     
     
    Show all issues

    typo: "typeS"

  3. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to dvcs (e60adaf)