Summary

Add utilities to compare DiffCommits and FileDiffs for equivalence

Review Request #8313 — Created July 27, 2016 and submitted July 29, 2016, 4:15 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Blocks

8315

Reviewers

Groups

reviewboard

People

Description

Two FileDiffs are equivalent if and only if they have the same diff
content (including headers). Instead of directly comparing the diff
contents we can instead see that they point at the same
RawFileDiffData object, as any two identical FileDiffs must have
identical RawFileDiffData instances.

Two DiffCommits are equivalent if and only if they have the same
author, committer, and diff contents. That is, every FileDiff in
DiffCommit A will have a corresponding equivalent Filediff in
DiffCommit B if A and B are equivalent. We cache the result of this
comparison in the extra_data of each DiffCommit to save future
database queries.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Do we need to list the full module path of FileDiff here?	david	July 28, 2016, 5:28 p.m.
Same question.	david	July 28, 2016, 5:28 p.m.
There's an extra line here.	david	July 28, 2016, 5:31 p.m.
This is doing a bitwise comparison. We should just have this be: else: if not self_diff.is_equivalent_to(other_diff): equivalent = False	david	July 28, 2016, 5:32 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/tests.py

reviewboard/diffviewer/models.py (Diff revision 1)

Show all issues

Do we need to list the full module path of FileDiff here?

brennie July 28, 2016, 5:31 p.m.

No, because FileDiff is defined in this module.

reviewboard/diffviewer/models.py (Diff revision 1)
Show all issues
```
Same question.
```
reviewboard/diffviewer/models.py (Diff revision 1)
Show all issues
```
There's an extra line here.
```

reviewboard/diffviewer/models.py (Diff revision 1)

Show all issues

This is doing a bitwise comparison. We should just have this be:

else:
    if not self_diff.is_equivalent_to(other_diff):
        equivalent = False

Change Summary:

Address David's issues.

Diff:

Revision 2 (+285 -16)

Show changes

	reviewboard/diffviewer/models.py
	reviewboard/diffviewer/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/tests.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (d609151)