Added import to logging module

Review Request #8309 — Created July 25, 2016 and submitted

mariusz
Review Board
master
68ec607...
reviewboard
Added import to logging module. Without this import error was thrown when logging var was called.

Tested on production ;)

Description From Last Updated

Must be in alphabetical order.

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
    
    
  2. 
      
MA
MA
TY
  1. Ship It!
  2. 
      
chipx86
  1. Thanks for the contribution!

    We use the description as the commit message, and like to have it be self-describing enough so that, without looking at the code, we know exactly what's been fixed. Something that would be useful to know in the description is that this pertains to GitLab.

    This change is small, so I'm less worried about this one. I can make that change myself. This is more useful for future reference :)

    One thing I would like to see in the update is which branch this is targeted for (rather than the pull request branch you're using). This helps us know if this is intended to land in release-2.0.x, release-2.5.x, etc. Should be the branch that first introduced the failure, so we can merge it to all applicable releases.

  2. reviewboard/hostingsvcs/gitlab.py (Diff revision 1)
     
     
     
     

    Must be in alphabetical order.

  3. 
      
MA
MA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
MA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (25c2f67)
Loading...