-
Thanks for the contribution!
We use the description as the commit message, and like to have it be self-describing enough so that, without looking at the code, we know exactly what's been fixed. Something that would be useful to know in the description is that this pertains to GitLab.
This change is small, so I'm less worried about this one. I can make that change myself. This is more useful for future reference :)
One thing I would like to see in the update is which branch this is targeted for (rather than the pull request branch you're using). This helps us know if this is intended to land in
release-2.0.x
,release-2.5.x
, etc. Should be the branch that first introduced the failure, so we can merge it to all applicable releases. -