Summary

Make use of rb-tfs.

Review Request #8302 — Created July 20, 2016 and submitted July 25, 2016, 5:57 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

572fa9b...

Reviewers

Groups

rbtools

People

Description

When using TFS, we've traditionally relied on Team Explorer Everywhere's

command-line interface. This is pretty slow and doesn't let us do things like

post shelvesets. In other changes, I've added a helper application built on the

TFS SDK which does what we need. With this change, if that helper is installed,

we use it instead of the old TEE command.

Testing Done

Posted pending changes and shelvesets to my local server.

Issues

Description	From	Last Updated
If these are optional, this should have , optional.	chipx86	July 21, 2016, 4:38 p.m.
If this is from argparse, then it's an argparse.Namespace.	chipx86	July 21, 2016, 4:39 p.m.
This will fail if options is None, as above.	chipx86	July 21, 2016, 4:40 p.m.
Needs the full module path.	chipx86	July 21, 2016, 4:39 p.m.
revisions is [] by default. If it's actually optional, we should say so here, but I suspect it should actually …	chipx86	July 21, 2016, 4:47 p.m.
Needs the full module path.	chipx86	July 21, 2016, 4:53 p.m.
Should list , optional.	chipx86	July 21, 2016, 4:47 p.m.
Same comments as above.	chipx86	July 21, 2016, 4:47 p.m.
Needs the full module path.	chipx86	July 21, 2016, 4:47 p.m.
Should this default to []?	chipx86	July 21, 2016, 4:48 p.m.
Should use double backticks for references to arguments.	chipx86	July 21, 2016, 4:48 p.m.
Double backticks for the values.	chipx86	July 21, 2016, 4:49 p.m.
This won't render correctly in ReST. Should be: This will return a dictionary with the following keys: ``base``: A revision …	chipx86	July 21, 2016, 4:50 p.m.
Needs full module paths.	chipx86	July 21, 2016, 4:53 p.m.
, optional	chipx86	July 21, 2016, 4:50 p.m.
Blank line between these.	chipx86	July 21, 2016, 4:51 p.m.
Can be: if rc in (0, 2):	chipx86	July 21, 2016, 4:51 p.m.
Missing trailing comma.	chipx86	July 21, 2016, 4:51 p.m.
"rb-tfs"?	chipx86	July 21, 2016, 4:51 p.m.
:py:meth:	chipx86	July 21, 2016, 4:51 p.m.
Same as above.	chipx86	July 21, 2016, 4:51 p.m.
Blank line between these.	chipx86	July 21, 2016, 4:52 p.m.
Needs to be a full module path.	chipx86	July 21, 2016, 4:52 p.m.
Same comments as above on double backticks for arguments and values.	chipx86	July 21, 2016, 4:52 p.m.
Same comments as above on ReST formatting.	chipx86	July 21, 2016, 4:52 p.m.
Should have , optional if the argument is optional.	chipx86	July 21, 2016, 4:52 p.m.
Needs full module paths.	chipx86	July 21, 2016, 4:53 p.m.
, optional	chipx86	July 21, 2016, 4:52 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tfs.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/tfs.py

Code seems fine. Most of my comments are about the docs.

rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
If these are optional, this should have , optional.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
If this is from argparse, then it's an argparse.Namespace.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This will fail if options is None, as above.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs the full module path.
```

rbtools/clients/tfs.py (Diff revision 1)

The issue has been resolved. Show all issues

revisions is [] by default. If it's actually optional, we should say so here, but I suspect it should actually not default to []?

rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs the full module path.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should list , optional.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same comments as above.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs the full module path.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should this default to []?
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use double backticks for references to arguments.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Double backticks for the values.
```

rbtools/clients/tfs.py (Diff revision 1)

The issue has been resolved. Show all issues

This won't render correctly in ReST. Should be:

This will return a dictionary with the following keys:

``base``:
    A revision to use ...

``tip``:
   A revision to use ...

rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs full module paths.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
, optional
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can be:

if rc in (0, 2):
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing trailing comma.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"rb-tfs"?
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
:py:meth:
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same as above.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs to be a full module path.
```

rbtools/clients/tfs.py (Diff revision 1)

The issue has been resolved. Show all issues

Same comments as above on double backticks for arguments and values.

rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same comments as above on ReST formatting.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should have , optional if the argument is optional.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs full module paths.
```
rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
, optional
```

Summary:

-	Make use of tf-helper.
+	Make use of rb-tfs.

Commit:

-	2e0b8476a22b726306f88ae6a24c9b82b162aef4
+	572fa9b2f61f95e685c6ebf84717e2073b95173c

Diff:

Revision 2 (+385 -169)

Show changes

rbtools/clients/tfs.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tfs.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/tfs.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (b9b6db2)