Summary

Status API part 2: Small refactor of reviewtags.

Review Request #8299 — Created July 19, 2016 and submitted Aug. 8, 2016, 2:37 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

bef087a...

Reviewers

Groups

reviewboard

People

Description

A couple template tags in the reviewtags library (reply_section and reply_list)
took an entry as a parameter, but the only part of the entry that they cared
about was the review. This change refactors that to pass in the review instead.

I've also changed the review box template to directly reference the review as a
variable rather than repeatedly accessing entry.review.

Testing Done


Verified that reviews and replies to reviews still displayed correctly.
Ran unit tests.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/templates/reviews/review_reply.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/templates/reviews/review_reply.html

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (1170afe)