Remove dead code from review_detail view on dvcs

Review Request #8285 — Created July 12, 2016 and submitted

Information

Review Board
dvcs
0d491ee...

Reviewers

In the review detail view, we are fetching all the DiffCommits on the
review request, organizating them according to their DiffSet and then
doing nothing with the result.

Verified the review detail view still works.

Description From Last Updated

'defaultdict' imported but unused

reviewbotreviewbot

'DiffCommit' imported but unused

reviewbotreviewbot

Is this variable still used? It doesn't look like it in my tree.

daviddavid

'defaultdict' imported but unused

reviewbotreviewbot

'DiffCommit' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     
     'defaultdict' imported but unused
    
  3. reviewboard/reviews/views.py (Diff revision 1)
     
     
     'DiffCommit' imported but unused
    
  4. 
      
chipx86
  1. Can you add more to the summary? It's not very self-explanatory yet.

  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
chipx86
  1. Looks like the changes actually cover a lot more than what the description says.

  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/reviews/views.py (Diff revision 3)
     
     

    Is this variable still used? It doesn't look like it in my tree.

    1. Indeed it is not. Thanks for catching!

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources/diff_context.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. 
      
david
  1. Can we put this on release-3.0.x instead of just dvcs?

    1. Only a small part of this change affects 3.0.x. The DiffCommit stuff is all dvcs-only.

      see: https://github.com/reviewboard/reviewboard/blob/release-3.0.x/reviewboard/reviews/views.py#L460-L463

      I can submit another patch to delete the dead code from release-3.0.x.

  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. reviewboard/reviews/views.py (Diff revision 7)
     
     
     'defaultdict' imported but unused
    
  3. reviewboard/reviews/views.py (Diff revision 7)
     
     
     'DiffCommit' imported but unused
    
  4. 
      
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (a1888e2)
Loading...