Remove dead code from review_detail view on dvcs
Review Request #8285 — Created July 12, 2016 and submitted
In the review detail view, we are fetching all the
DiffCommit
s on the
review request, organizating them according to theirDiffSet
and then
doing nothing with the result.
Verified the review detail view still works.
Summary: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+22 -24) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/diff_context.py Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/diff_context.py Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py
-
-
reviewboard/reviews/views.py (Diff revision 3) Is this variable still used? It doesn't look like it in my tree.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+22 -25) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/diff_context.py Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/diff_context.py Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py
Depends On: |
|
||
---|---|---|---|
Diff: |
Revision 6 (+1 -2) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py
-
-