Summary

Remove dead code from review_detail view on dvcs

Review Request #8285 — Created July 12, 2016 and submitted July 19, 2016, 3:54 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

~~8291~~

Commit

0d491ee...

Reviewers

Groups

reviewboard

People

Description

In the review detail view, we are fetching all the DiffCommits on the
review request, organizating them according to their DiffSet and then
doing nothing with the result.

Testing Done

Verified the review detail view still works.

Issues

Description	From	Last Updated
'defaultdict' imported but unused	reviewbot	July 12, 2016, 1:10 a.m.
'DiffCommit' imported but unused	reviewbot	July 12, 2016, 1:10 a.m.
Is this variable still used? It doesn't look like it in my tree.	david	July 14, 2016, 5:39 p.m.
'defaultdict' imported but unused	reviewbot	July 16, 2016, 1:16 p.m.
'DiffCommit' imported but unused	reviewbot	July 16, 2016, 1:16 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'defaultdict' imported but unused
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'DiffCommit' imported but unused
```

Can you add more to the summary? It's not very self-explanatory yet.

Summary:

Remove dead code

Remove dead code from review_detail view

Commit:

f5d6873dfb5ef6142045f6923e6283224d5708f6

Diff:

Revision 2 (+22 -24)

Show changes

	reviewboard/reviews/views.py
	reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.js
	reviewboard/webapi/resources/diff_context.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Looks like the changes actually cover a lot more than what the description says.

Change Summary:

Upload the right branch :)

Diff:

Revision 3 (+1 -10)

Show changes

reviewboard/reviews/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Is this variable still used? It doesn't look like it in my tree.
```
1. brennie July 14, 2016, 5:39 p.m.
  Indeed it is not. Thanks for catching!

Commit:

f5d6873dfb5ef6142045f6923e6283224d5708f6

0d491ee64e226be102c78a4c14565221f4afe6be

Diff:

Revision 4 (+22 -25)

Show changes

	reviewboard/reviews/views.py
	reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.js
	reviewboard/webapi/resources/diff_context.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources/diff_context.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Change Summary:

Post only the correct change.

Diff:

Revision 5 (+1 -11)

Show changes

reviewboard/reviews/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Can we put this on release-3.0.x instead of just dvcs?

brennie July 16, 2016, 1:04 p.m.

Only a small part of this change affects 3.0.x. The DiffCommit stuff is all dvcs-only.

see: https://github.com/reviewboard/reviewboard/blob/release-3.0.x/reviewboard/reviews/views.py#L460-L463

I can submit another patch to delete the dead code from release-3.0.x.

Depends On:

~~8291 - Remove dead code from review_detail view on release-3.0.x~~

Diff:

Revision 6 (+1 -2)

Show changes

reviewboard/reviews/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Change Summary:

Upload correct patch

Diff:

Revision 7 (-7)

Show changes

reviewboard/reviews/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

reviewboard/reviews/views.py (Diff revision 7)
The issue has been resolved. Show all issues
```
 'defaultdict' imported but unused
```
reviewboard/reviews/views.py (Diff revision 7)
The issue has been resolved. Show all issues
```
 'DiffCommit' imported but unused
```

Summary:: Remove dead code from review_detail view
Remove dead code from review_detail view on dvcs

Change Summary:

flake8

Diff:

Revision 8 (+1 -9)

Show changes

reviewboard/reviews/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (a1888e2)