Add support for commit history information in the DiffCommitResource

Review Request #8276 — Created July 8, 2016 and submitted

Information

Review Board
dvcs
9c0e322...

Reviewers

The DiffCommitResource now accepts the original commit IDs of a commit
when creating. These IDs can be used to show the evolution of a commit
history over time, e.g., when two commits get squashed into one commit
or a commit is amended.

The ValidateDiffCommitResource has also been updated to accept the
required fields.

  • Ran unit tests.
  • Used https://reviews.reviewboard.org/r/8278/ to upload a rebased
    patch with rbt and saw the relationships in the database.
Description From Last Updated

local variable 'diffset' is assigned to but never used

reviewbotreviewbot

'webapi_test_template' imported but unused

reviewbotreviewbot

'DiffSet' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/draft_diff_commit.py
        reviewboard/diffviewer/models.py
        reviewboard/webapi/tests/test_draft_diff_commit.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/resources/diff_commit.py
        reviewboard/diffviewer/forms.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/draft_diff_commit.py
        reviewboard/diffviewer/models.py
        reviewboard/webapi/tests/test_draft_diff_commit.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/resources/diff_commit.py
        reviewboard/diffviewer/forms.py
    
    
  2. reviewboard/diffviewer/tests.py (Diff revision 1)
     
     
    Show all issues
     local variable 'diffset' is assigned to but never used
    
  3. Show all issues
     'webapi_test_template' imported but unused
    
  4. Show all issues
     'DiffSet' imported but unused
    
  5. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/draft_diff_commit.py
        reviewboard/diffviewer/models.py
        reviewboard/webapi/tests/test_draft_diff_commit.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/resources/diff_commit.py
        reviewboard/diffviewer/forms.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/draft_diff_commit.py
        reviewboard/diffviewer/models.py
        reviewboard/webapi/tests/test_draft_diff_commit.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/resources/diff_commit.py
        reviewboard/diffviewer/forms.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/draft_diff_commit.py
        reviewboard/diffviewer/models.py
        reviewboard/webapi/tests/test_draft_diff_commit.py
        reviewboard/webapi/resources/validate_diff_commit.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/resources/diff_commit.py
        reviewboard/diffviewer/forms.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/draft_diff_commit.py
        reviewboard/diffviewer/models.py
        reviewboard/webapi/tests/test_draft_diff_commit.py
        reviewboard/webapi/resources/validate_diff_commit.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/resources/diff_commit.py
        reviewboard/diffviewer/forms.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to dvcs (7024633)