Summary

Add support for commit history information in the DiffCommitResource

Review Request #8276 — Created July 8, 2016 and submitted July 16, 2016, 1:24 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

9c0e322...

Reviewers

Groups

reviewboard

People

Description

The DiffCommitResource now accepts the original commit IDs of a commit
when creating. These IDs can be used to show the evolution of a commit
history over time, e.g., when two commits get squashed into one commit
or a commit is amended.

The ValidateDiffCommitResource has also been updated to accept the
required fields.

Testing Done


Ran unit tests.
Used https://reviews.reviewboard.org/r/8278/ to upload a rebased

  patch with rbt and saw the relationships in the database.

Issues

Description	From	Last Updated
local variable 'diffset' is assigned to but never used	reviewbot	July 8, 2016, 5:29 p.m.
'webapi_test_template' imported but unused	reviewbot	July 8, 2016, 5:29 p.m.
'DiffSet' imported but unused	reviewbot	July 8, 2016, 5:29 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/tests/test_draft_diff_commit.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/tests/test_draft_diff_commit.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py

reviewboard/diffviewer/tests.py (Diff revision 1)

Show all issues

 local variable 'diffset' is assigned to but never used

reviewboard/webapi/tests/test_draft_diff_commit.py (Diff revision 1)
Show all issues
```
 'webapi_test_template' imported but unused
```
reviewboard/webapi/tests/test_draft_diff_commit.py (Diff revision 1)
Show all issues
```
 'DiffSet' imported but unused
```

Change Summary:

Cleanup

Diff:

Revision 2 (+273 -36)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/models.py
	reviewboard/diffviewer/tests.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff_commit.py
	reviewboard/webapi/tests/test_draft_diff_commit.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/tests/test_draft_diff_commit.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/tests/test_draft_diff_commit.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py

Description:

		The `DiffCommitResource` now accepts the original commit IDs of a commit
		when creating. These IDs can be used to show the evolution of a commit
		history over time, e.g., when two commits get squashed into one commit
		or a commit is amended.
	+
	+	The `ValidateDiffCommitResource` has also been updated to accept the
	+	required fields.

Testing Done:

~		Ran unit tests.
	~	Ran unit tests.
	+	Used https://reviews.reviewboard.org/r/8278/ to upload a rebased patch with `rbt` and saw the relationships in the database.

Commit:

-	167e2372eaffc8c77637cf8039332a2a03dd3b0b
+	9c0e32230ede1162b8ee1035de27a4c08714d3e9

Diff:

Revision 3 (+285 -36)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/models.py
	reviewboard/diffviewer/tests.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff_commit.py
	reviewboard/webapi/resources/validate_diff_commit.py
	reviewboard/webapi/tests/test_draft_diff_commit.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/tests/test_draft_diff_commit.py
    reviewboard/webapi/resources/validate_diff_commit.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/tests/test_draft_diff_commit.py
    reviewboard/webapi/resources/validate_diff_commit.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (7024633)