• 
      

    Fix jasmine-suites support for Jasmine 1.4.

    Review Request #8271 — Created July 7, 2016 and submitted

    Information

    Review Board
    release-3.0.x
    1813dd5...

    Reviewers

    Jasmine 1.4 changed how they kept state when building the tree of
    suites and specs, and this broke a number of things with jasmine-suites.
    Suites would lose their hierarchy and running specific specs wouldn't
    work quite right.
    
    This updates jasmine-suites to build the tree properly on Jasmine 1.4.
    It basically has to get in and rearrange the tree of the currently-built
    Jasmine Suite in a describe() call, changing things out from under
    Jasmine and fixing up some state. Jasmine doesn't really mind this,
    fortunately, meaning we can retain the abilities we had before.

    Ran our test suite and saw that the tree of suites/specs were correct.
    Saw that the links were correct for initial and added-on suites.

    Description From Last Updated

    Oh, this should go into https://github.com/beanbaginc/jasmine-suites, shouldn't it?

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/lib/js/jasmine.suites-1.0.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/lib/js/jasmine.suites-1.0.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    david
    1. 
        
    2. Show all issues

      Oh, this should go into https://github.com/beanbaginc/jasmine-suites, shouldn't it?

      1. Yep, we just don't have that on RBCommons. I'm going to update that, and also make a repo for the other one I have up.

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (461d783)