Add visual feedback when clicking "Show content" for deleted files.

Review Request #8262 — Created June 29, 2016 and submitted

Information

Review Board
release-3.0.x
ec8f3ab...

Reviewers

It's usually pretty quick to load the content for deleted files, but sometimes
things can be laggy. This change adds a spinner that's shown in the interval
between clicking "Show content" and the actual loading of said content.

Clicked a link. Saw a spinner.

Description From Last Updated

Mind adding a small comment saying we're showing a spinner, and that it'll be automatically replaced when the diff is …

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    
    
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    Mind adding a small comment saying we're showing a spinner, and that it'll be automatically replaced when the diff is shown? Just so it's more clear down the road and to contributors.

  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (149a865)