Add visual feedback when clicking "Show content" for deleted files.
Review Request #8262 — Created June 29, 2016 and submitted
It's usually pretty quick to load the content for deleted files, but sometimes
things can be laggy. This change adds a spinner that's shown in the interval
between clicking "Show content" and the actual loading of said content.
Clicked a link. Saw a spinner.
| Description | From | Last Updated |
|---|---|---|
|
Mind adding a small comment saying we're showing a spinner, and that it'll be automatically replaced when the diff is … |
 chipx86
|
-
-
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 1) Mind adding a small comment saying we're showing a spinner, and that it'll be automatically replaced when the diff is shown? Just so it's more clear down the road and to contributors.
Change Summary:
Add a comment.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+8) |
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js