Check if avatars are enabled at runtime instead of startup

Review Request #8252 — Created June 19, 2016 and submitted

Information

Review Board
release-3.0.x
d89204a...

Reviewers

Previously, we would add the AvatarSettingsForm to the ProfilePage
if, upon startup, the avatar services were enabled for the server.
However, this prevented creating a new database with manage.py syncdb.
We now use the is_visible method on the ProfileForm to determine
whether or not it should be shown.

  • Verified the avatar form is only shown when avatars are enabled.
  • Ran unit tests.
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/__init__.py
        reviewboard/accounts/forms/pages.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/__init__.py
        reviewboard/accounts/forms/pages.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (e9f0321)
Loading...