Summary

Fix encoding of floating point values into XML.

Review Request #8249 — Created June 18, 2016 and submitted June 21, 2016, 10:07 p.m.

Information

Owner

gmyers

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Blocks

8250

Commit

042f04c...

Reviewers

Groups

djblets

People

Description

The encoding functionality in XMLEncoderAdapter would throw an exception
when encountering a floating point value, indicating that the value was not
XML serializable. This has been corrected by adding special handing for
floating point values, analogous to how other data types are handled.

Testing Done

Added new unit tests to exercise both the JSON and XML encoder adapters.
Encoding is attempted on a variety of data types.  Prior to the fix, the
XML-based test would fail due to the presence of floating point data types.

Issues

Description	From	Last Updated
Col: 44 W292 no newline at end of file	reviewbot	June 18, 2016, 7:39 p.m.
Col: 1 W391 blank line at end of file	reviewbot	June 18, 2016, 7:41 p.m.

Tool: Pyflakes
Processed Files:
    djblets/webapi/tests/test_encoders.py
    djblets/webapi/encoders.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/tests/test_encoders.py
    djblets/webapi/encoders.py

djblets/webapi/tests/test_encoders.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 44
 W292 no newline at end of file
```

Change Summary:

Fix ReviewBot issue.

Commit:

80ccdd818677143e9ed0655c238d82595df0e6dc

83d5391a42751046cb07602cbe7111971a6140fc

Diff:

Revision 2 (+62)

Show changes

	djblets/webapi/encoders.py
	djblets/webapi/tests/test_encoders.py

Tool: Pyflakes
Processed Files:
    djblets/webapi/tests/test_encoders.py
    djblets/webapi/encoders.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/tests/test_encoders.py
    djblets/webapi/encoders.py

djblets/webapi/tests/test_encoders.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Change Summary:

ReviewBot again.

Commit:

83d5391a42751046cb07602cbe7111971a6140fc

042f04cdf3f26a775b915e2721c2021f869879c7

Diff:

Revision 3 (+61)

Show changes

	djblets/webapi/encoders.py
	djblets/webapi/tests/test_encoders.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/tests/test_encoders.py
    djblets/webapi/encoders.py



Tool: Pyflakes
Processed Files:
    djblets/webapi/tests/test_encoders.py
    djblets/webapi/encoders.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (a098afe)