Fix call to local_site_reverse in bugs column

Review Request #8244 — Created June 14, 2016 and submitted

Information

Review Board
release-2.5.x
73de3ca...

Reviewers

The BugsColumn was calling local_site_reverse with args as a tuple
instead of a list, which would cause an exception when the repository
had a bug tracker configured. This has been corrected by updating the
calling point to use a list instead of a tuple and inside the
local_site_reverse to cast args to a list before concatenation.

The parameters of local_site_reverse have also been documented.

  • Ran unit tests.
  • Viewed the dashboard with a review request filed against a repository
    with a bug tracker. Without this fix applied, the exception occured;
    with it applied, it did not.
Description From Last Updated

While here, can you make the following changes: "Reverse" A reference for reverse() "Local Site" instead of "localsite"

chipx86chipx86

Sentence seems a bit weird. Probably want "... and return ..."

chipx86chipx86

The "or" is ambiguous. Can easily be read as: ... returning a LocalSite version of a URL (when invoked with …

chipx86chipx86

"use"

chipx86chipx86

This is optional, too.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/site/urlresolvers.py
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/site/urlresolvers.py
        reviewboard/datagrids/columns.py
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/site/urlresolvers.py (Diff revision 1)
     
     
     
     
     
     

    While here, can you make the following changes:

    • "Reverse"
    • A reference for reverse()
    • "Local Site" instead of "localsite"
  3. reviewboard/site/urlresolvers.py (Diff revision 1)
     
     
  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/site/urlresolvers.py
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/site/urlresolvers.py
        reviewboard/datagrids/columns.py
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/site/urlresolvers.py (Diff revisions 1 - 2)
     
     

    Sentence seems a bit weird. Probably want "... and return ..."

  3. reviewboard/site/urlresolvers.py (Diff revisions 1 - 2)
     
     
     
     

    The "or" is ambiguous. Can easily be read as:

    ... returning a LocalSite version of a URL (when invoked with a request within a LocalSite) or either a local_site_name or local_site agruments.
    

    How about:

    ... returning a Local Site version of the URL when invoked with one of the following:
    * A ``request`` argument representing an HTTP request to a URL within a Local Site.
    * A ``local_site_name`` argument.
    * A ``local_site`` argument.
    
  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/site/urlresolvers.py
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/site/urlresolvers.py
        reviewboard/datagrids/columns.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/site/urlresolvers.py (Diff revision 3)
     
     

    This is optional, too.

  3. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (30fd905)
Loading...