Fix call to local_site_reverse in bugs column
Review Request #8244 — Created June 14, 2016 and submitted
The
BugsColumnwas callinglocal_site_reversewithargsas a tuple
instead of a list, which would cause an exception when the repository
had a bug tracker configured. This has been corrected by updating the
calling point to use a list instead of a tuple and inside the
local_site_reverseto castargsto a list before concatenation.The parameters of
local_site_reversehave also been documented.
- Ran unit tests.
- Viewed the dashboard with a review request filed against a repository
with a bug tracker. Without this fix applied, the exception occured;
with it applied, it did not.
| Description | From | Last Updated |
|---|---|---|
|
While here, can you make the following changes: "Reverse" A reference for reverse() "Local Site" instead of "localsite" |
 chipx86
|
|
|
Sentence seems a bit weird. Probably want "... and return ..." |
chipx86
|
|
|
The "or" is ambiguous. Can easily be read as: ... returning a LocalSite version of a URL (when invoked with … |
chipx86
|
|
|
"use" |
chipx86
|
|
|
This is optional, too. |
 david
|
- Change Summary:
-
Address Christian's issues.
- Commit:
-
7382941c7a9fff48560b5c04ba1389e53b8bf92d73de3ca28fd864fe2374260df17988c527a89378
-
Tool: Pyflakes Processed Files: reviewboard/site/urlresolvers.py reviewboard/datagrids/columns.py Tool: PEP8 Style Checker Processed Files: reviewboard/site/urlresolvers.py reviewboard/datagrids/columns.py
-
-
-
The "or" is ambiguous. Can easily be read as:
... returning a LocalSite version of a URL (when invoked with a request within a LocalSite) or either a local_site_name or local_site agruments.How about:
... returning a Local Site version of the URL when invoked with one of the following: * A ``request`` argument representing an HTTP request to a URL within a Local Site. * A ``local_site_name`` argument. * A ``local_site`` argument.
Tool: Pyflakes Processed Files: reviewboard/site/urlresolvers.py reviewboard/datagrids/columns.py Tool: PEP8 Style Checker Processed Files: reviewboard/site/urlresolvers.py reviewboard/datagrids/columns.py