Summary

Sandbox WebHook dispatch

Review Request #8235 — Created June 10, 2016 and submitted June 10, 2016, 7:37 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

b99f649...

Reviewers

Groups

reviewboard

People

Description

Previously, WebHook dispatch could trigger several exceptions that were
not caught and this could lead to broken state. Now, we catch these
exceptions and log them. Unit tests have been added to ensure that these
errors do not bubble up.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Should be a raw string. Also space before the %}.	chipx86	June 10, 2016, 7:21 p.m.
I think we should just catch anything and everything.	chipx86	June 10, 2016, 7:21 p.m.
Same here. Let's catch everything. We don't want anything slipping by.	chipx86	June 10, 2016, 7:21 p.m.
Here, too.	chipx86	June 10, 2016, 7:21 p.m.
'TemplateSyntaxError' imported but unused	reviewbot	June 10, 2016, 7:26 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py

reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should be a raw string.
Also space before the %}.
```
reviewboard/notifications/webhooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I think we should just catch anything and everything.
```
reviewboard/notifications/webhooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here. Let's catch everything. We don't want anything slipping by.
```
reviewboard/notifications/webhooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Here, too.
```

Change Summary:

Address Chistian's issues.

Commit:

dc9a81e36277f3792c8311c9b4ae604ba70d080d

3ef21b8aba580b5f48849d0c72a6cf7ab2033c04

Diff:

Revision 2 (+94 -20)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py

reviewboard/notifications/webhooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 'TemplateSyntaxError' imported but unused
```

Change Summary:

PEP8

Commit:

3ef21b8aba580b5f48849d0c72a6cf7ab2033c04

b99f649571d819317d0363ded715b4b14b92f56b

Diff:

Revision 3 (+93 -19)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (a2250b3)