Sandbox WebHook dispatch
Review Request #8235 — Created June 10, 2016 and submitted
Previously, WebHook dispatch could trigger several exceptions that were
not caught and this could lead to broken state. Now, we catch these
exceptions and log them. Unit tests have been added to ensure that these
errors do not bubble up.
Ran unit tests.
-
-
reviewboard/notifications/tests.py (Diff revision 1) Should be a raw string.
Also space before the
%}. -
reviewboard/notifications/webhooks.py (Diff revision 1) I think we should just catch anything and everything.
-
reviewboard/notifications/webhooks.py (Diff revision 1) Same here. Let's catch everything. We don't want anything slipping by.
-
Change Summary:
Address Chistian's issues.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+94 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/notifications/webhooks.py reviewboard/notifications/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/webhooks.py reviewboard/notifications/tests.py -
Change Summary:
PEP8
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+93 -19) |
Tool: Pyflakes Processed Files: reviewboard/notifications/webhooks.py reviewboard/notifications/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/webhooks.py reviewboard/notifications/tests.py