Sandbox WebHook dispatch
Review Request #8235 — Created June 10, 2016 and submitted
Previously, WebHook dispatch could trigger several exceptions that were
not caught and this could lead to broken state. Now, we catch these
exceptions and log them. Unit tests have been added to ensure that these
errors do not bubble up.
Ran unit tests.
| Description | From | Last Updated | ||
|---|---|---|---|---|
|
Should be a raw string. Also space before the %}. |
 chipx86
|
|||
|
I think we should just catch anything and everything. |
chipx86
|
|||
|
Same here. Let's catch everything. We don't want anything slipping by. |
chipx86
|
|||
|
Here, too. |
chipx86
|
|||
|
'TemplateSyntaxError' imported but unused |
 reviewbot
|
|||
| There are no open issues | ||||
- Change Summary:
-
Address Chistian's issues.
- Commit:
-
dc9a81e36277f3792c8311c9b4ae604ba70d080d3ef21b8aba580b5f48849d0c72a6cf7ab2033c04
- Change Summary:
-
PEP8
- Commit:
-
3ef21b8aba580b5f48849d0c72a6cf7ab2033c04b99f649571d819317d0363ded715b4b14b92f56b
Tool: Pyflakes Processed Files: reviewboard/notifications/webhooks.py reviewboard/notifications/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/webhooks.py reviewboard/notifications/tests.py