Fix WebHook signatures to follow our documentation.

Review Request #8231 — Created June 10, 2016 and submitted

Information

Review Board
release-2.5.x
9c594ea...

Reviewers

Our documentation on the way WebHook payloads are signed claimed to use SHA-1
hashes for HMAC, but in reality, we were using MD5. This is because we were
failing to pass in the hash method to the HMAC library.

Ran unit tests.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/webhooks.py
        reviewboard/notifications/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/webhooks.py
        reviewboard/notifications/tests.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (52b1b1c)
Loading...