Summary

Copy commit information to draft instead of review request

Review Request #8230 — Created June 10, 2016 and submitted June 10, 2016, 1:52 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

458085e...

Reviewers

Groups

reviewboard

People

Description

When creating review requests from existing commits, we now copy the
data into a new review request draft instead of into the review request.
This has the effect of showing the draft banner when creating the review
request (previously, the review request would have to be edited to
create a draft) and allowing publishing immediately (if there are
default reviewers). Unit tests have been updated to reflect this new
behaviour.

Testing Done


Created a review request through post-commit UI. The banner appeared

  immediately and I was able to submit it.
Ran unit tests.

Issues

Description	From	Last Updated
Haven't we already set the commit_id and saved above?	david	June 10, 2016, 1:08 p.m.
Let's keep the asserts, but assert that they're empty. Same with the review request below.	chipx86	June 10, 2016, 1:41 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/reviews/managers.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/reviews/managers.py

reviewboard/reviews/managers.py (Diff revision 1)

The issue has been dropped. Show all issues

Haven't we already set the commit_id and saved above?

brennie

June 10, 2016, 1:09 p.m.

No. We set it above if commit_id and not create_from_commit_id. This is the case of commit_id and create_from_commit_id where copying from the repository has failed.

reviewboard/webapi/tests/test_review_request.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's keep the asserts, but assert that they're empty.

Same with the review request below.

Change Summary:

Addressed Christian's issues

Commit:

14950d1e24db1e22264e37d1239516805220a646

458085eb2074e3611332e5600259111596bbc06d

Diff:

Revision 2 (+29 -18)

Show changes

	reviewboard/reviews/managers.py
	reviewboard/webapi/tests/test_review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/reviews/managers.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/reviews/managers.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (65cc60b)