Copy commit information to draft instead of review request
Review Request #8230 — Created June 10, 2016 and submitted
When creating review requests from existing commits, we now copy the
data into a new review request draft instead of into the review request.
This has the effect of showing the draft banner when creating the review
request (previously, the review request would have to be edited to
create a draft) and allowing publishing immediately (if there are
default reviewers). Unit tests have been updated to reflect this new
behaviour.
- Created a review request through post-commit UI. The banner appeared
immediately and I was able to submit it. - Ran unit tests.
-
-
reviewboard/reviews/managers.py (Diff revision 1) Haven't we already set the commit_id and saved above?
-
-
reviewboard/webapi/tests/test_review_request.py (Diff revision 1) Let's keep the asserts, but assert that they're empty.
Same with the review request below.
Change Summary:
Addressed Christian's issues
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+29 -18) |
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_review_request.py reviewboard/reviews/managers.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_review_request.py reviewboard/reviews/managers.py