-
-
-
reviewboard/notifications/tests.py (Diff revision 1) redefinition of unused 'test_review_published' from line 1729
-
reviewboard/notifications/webhooks.py (Diff revision 1) local variable 'local_site_name' is assigned to but never used
Fix WebHook dispatch for local sites
Review Request #8229 — Created June 10, 2016 and submitted
WebHooks dispatched from events triggered from local sites would fail
because the WebAPIEncoder would not have access to the local site to
completelocal_site_reverse
calls. We now pass in the name of the
local site to ourFakeHTTPRequest
class and store it on the instance
wherelocal_site_reverse
can find it. New unit tests have been added
to test each signal that triggers WebHook dispatch with a local site.
- Saw that WebHooks fired when creating and updating review requests for
local sites. - Ran unit tests.