Summary

Fix WebHook dispatch for local sites

Review Request #8229 — Created June 10, 2016 and submitted June 10, 2016, 1:48 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

2e2c3c4...

Reviewers

Groups

reviewboard

People

Description

WebHooks dispatched from events triggered from local sites would fail

because the WebAPIEncoder would not have access to the local site to

complete local_site_reverse calls. We now pass in the name of the

local site to our FakeHTTPRequest class and store it on the instance

where local_site_reverse can find it. New unit tests have been added

to test each signal that triggers WebHook dispatch with a local site.

Testing Done


Saw that WebHooks fired when creating and updating review requests for

  local sites.
Ran unit tests.

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	June 10, 2016, 10:13 a.m.
redefinition of unused 'test_review_published' from line 1729	reviewbot	June 10, 2016, 10:12 a.m.
local variable 'local_site_name' is assigned to but never used	reviewbot	June 10, 2016, 10:13 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py

reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 redefinition of unused 'test_review_published' from line 1729
```
reviewboard/notifications/webhooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'local_site_name' is assigned to but never used
```

Diff:

Revision 2 (+234 -17)

Show changes

	reviewboard/notifications/tests.py
	reviewboard/notifications/webhooks.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/notifications/tests.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (6aa3d5d)