Summary

Do some WebHook-related cleanups

Review Request #8223 — Created June 7, 2016 and submitted June 7, 2016, 10:08 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

f3bd51b...

Reviewers

Groups

reviewboard

People

Description

The default fieldset for WebHooks in the admin form now has a label
instead of None. In addition, the __str__ method of
WebHookTargets now just returns the URL, which is a more readable
string for viewing in the admin panel.

Testing Done

Description:

~		This change adds a `name` property to WebHooks so that they are similar
~		to other models that have a `name` field. In addition, The default
~		fieldset in the admin has been changed to have a label instead of
~		`None`.
	~	The default fieldset for WebHooks in the admin form now has a label
	~	instead of `None`. In addition, the `__str__` method of
	~	`WebHookTarget`s now just returns the URL, which is a more readable
	~	string for viewing in the admin panel.

Commit:

-	fe699af2954c24f645c9546c47ea6358e8b9b29e
+	f3bd51b09acd506eea21d4f715577b2b0ff51c12

Diff:

Revision 2 (+2 -3)

Show changes

	reviewboard/notifications/admin.py
	reviewboard/notifications/models.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (d423ccb)

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/models.py
    reviewboard/notifications/admin.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/models.py
    reviewboard/notifications/admin.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/models.py
    reviewboard/notifications/admin.py



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/models.py
    reviewboard/notifications/admin.py