Don't use -u in git diff-tree

Review Request #8222 — Created June 7, 2016 and submitted

Information

RBTools
release-0.7.x
e103333...

Reviewers

When generating diffs for SVN and Perforce with excluded files, we would
pass -u to git diff-tree, which generates diff output instead of the
list of changed files and break the parsing. Now, we remove the -u
flag from the git diff-tree command when generating the excluded files
list for SVN or Perforce repositories.


 
Description From Last Updated

Is this not a problem for plain git as well? If I run with -u locally, I get the diff …

chipx86chipx86
chipx86
  1. 
      
  2. rbtools/clients/git.py (Diff revision 1)
     
     
     
     

    Is this not a problem for plain git as well? If I run with -u locally, I get the diff information.

    1. We only use -u with SVN and Perforce (see line 508).

  3. 
      
chipx86
  1. Ship It!
  2. 
      
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/git.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/clients/git.py
    
    
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (e1e3993)
Loading...