Summary

Don't use -u in git diff-tree

Review Request #8222 — Created June 7, 2016 and submitted June 9, 2016, 9:38 a.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

e103333...

Reviewers

Groups

rbtools

People

Description

When generating diffs for SVN and Perforce with excluded files, we would
pass -u to git diff-tree, which generates diff output instead of the
list of changed files and break the parsing. Now, we remove the -u
flag from the git diff-tree command when generating the excluded files
list for SVN or Perforce repositories.

Testing Done

Issues

Description	From	Last Updated
Is this not a problem for plain git as well? If I run with -u locally, I get the diff …	chipx86	June 7, 2016, 4:17 p.m.

rbtools/clients/git.py (Diff revision 1)

The issue has been dropped. Show all issues

Is this not a problem for plain git as well? If I run with -u locally, I get the diff information.

brennie June 7, 2016, 4:17 p.m.

We only use -u with SVN and Perforce (see line 508).

Ship it!

```
Ship It!
```

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/git.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/git.py

Status:: Completed
Change Summary:: Pushed to release-0.7.x (e1e3993)