Summary

A pre-commit svn hook that forces approved review to commit.

Review Request #822 — Created April 19, 2009 and discarded

Information

Owner

raul_apache

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A pre-commit hook that checks if the corresponding review has been approved before let the commit proceed. 
The review number is obtained from the commit message as the number before REVIEW: keyword if, REVIEW: new is found a new review is created as the user doing the SVN commit.
With this hooks the clients doesn't need any program installed to post reviews as everything is done by the hook, simplifying a lot the setup of new contributers.

Testing Done

Test in command line, eclipse, netbeans clients.
Working non stop for 3 months in a real deployment.

Screenshots

review states

Screenshot Captions:: ReviewPRocess.png:
revie states
review states

ReviewPRocess.png:	revie states review states

/precommit-hook (Diff revision 1)
```
Trailing whitespace.
```

/precommit-hook (Diff revision 1)

This instruction is out of date with the way rbtools works now; postreview.py is installed as rbtools.postreview, and a script is created by setup.py which just enters into it.

/precommit-hook (Diff revision 1)
```
Typo - reviewboard
```

/precommit-hook (Diff revision 1)

Trailing whitespace. Please go through and fix these up.

/precommit-hook (Diff revision 1)

Please go through and make sure that all indentation is 4 spaces, no tabs.

/precommit-hook (Diff revision 1)
```
You don't need the parentheses.
```
/precommit-hook (Diff revision 1)
```
Add a space between parameters
```
/precommit-hook (Diff revision 1)
```
All imports should go at the top.
```

/precommit-hook (Diff revision 1)

This comment should probably be a docstring instead of a comment.

/precommit-hook (Diff revision 1)

This line should be wrapped to 80 characters

/precommit-hook (Diff revision 1)

Wrap these to 80 characters.

/precommit-hook (Diff revision 1)
```
Wrap to 80 characters.
```

/precommit-hook (Diff revision 1)

Same here and throughout the rest of the file.

Ship it!

```
testing review
```

Ship it!

```
test revieed
```