Add support for customizable avatar services

Review Request #8206 — Created June 1, 2016 and submitted

Information

Review Board
release-3.0.x
1371b8d...

Reviewers

Review Board now supports Djblets' customizable avatar services. It
provides a settings manager for saving per-user configuration for each
avatar service into that user's profile (under the settings key).

  • Ran unit tests.
  • Changed my avatar to an uploaded avatar.

Description From Last Updated

I don't think it makes sense to have the extra "Configure Avatar Service" header. Just have the extra stuff appear …

daviddavid

Hmm. I'd expect the drop-down and "Browse" button to be inline with the form labels.

daviddavid

'basictag' imported but unused

reviewbotreviewbot

local variable 'profile' is assigned to but never used

reviewbotreviewbot

Hmm. Is it really worth having a separate page just for the avatar or should we fold it into the …

daviddavid

avatar isn't its own page anymore, right?

daviddavid

This could probably just be return list(AccountPage.registry)

daviddavid

undo

brenniebrennie

undo

brenniebrennie

I don't see anything in this file that uses stuff from defs?

daviddavid

undo

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/ui/boxes.less
        reviewboard/static/rb/css/pages/my-account.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/ui/boxes.less
        reviewboard/static/rb/css/pages/my-account.less
    
    
  2.  'basictag' imported but unused
    
  3. reviewboard/avatars/tests.py (Diff revision 1)
     
     
     local variable 'profile' is assigned to but never used
    
  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/ui/boxes.less
        reviewboard/static/rb/css/pages/my-account.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/ui/boxes.less
        reviewboard/static/rb/css/pages/my-account.less
    
    
  2. 
      
brennie
david
  1. 
      
  2. I don't think it makes sense to have the extra "Configure Avatar Service" header. Just have the extra stuff appear below the drop-down when a configurable one is created.

  3. Hmm. I'd expect the drop-down and "Browse" button to be inline with the form labels.

    1. All account pages have the fields on the next line.

  4. reviewboard/accounts/tests.py (Diff revision 2)
     
     
     

    Hmm. Is it really worth having a separate page just for the avatar or should we fold it into the profile page?

  5. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/accounts/forms/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/ui/boxes.less
        reviewboard/static/rb/css/pages/my-account.less
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/accounts/forms/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/ui/boxes.less
        reviewboard/static/rb/css/pages/my-account.less
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/accounts/tests.py (Diff revision 3)
     
     
     

    avatar isn't its own page anymore, right?

  3. reviewboard/accounts/views.py (Diff revision 3)
     
     
     
     
     

    This could probably just be return list(AccountPage.registry)

  4. I don't see anything in this file that uses stuff from defs?

  5. 
      
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/accounts/forms/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/avatars/tests.py
        reviewboard/accounts/views.py
        reviewboard/accounts/pages.py
        reviewboard/accounts/forms/pages.py
        reviewboard/avatars/settings.py
        reviewboard/avatars/registry.py
        reviewboard/accounts/models.py
        reviewboard/avatars/templatetags/avatars.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (f4c9a8f)
Loading...