Add support for customizable avatar services
Review Request #8206 — Created June 1, 2016 and submitted
Review Board now supports Djblets' customizable avatar services. It
provides a settings manager for saving per-user configuration for each
avatar service into that user's profile (under thesettingskey).
- Ran unit tests.
- Changed my avatar to an uploaded avatar.
| Description | From | Last Updated |
|---|---|---|
|
I don't think it makes sense to have the extra "Configure Avatar Service" header. Just have the extra stuff appear … |
 david
|
|
|
Hmm. I'd expect the drop-down and "Browse" button to be inline with the form labels. |
david
|
|
|
'basictag' imported but unused |
 reviewbot
|
|
|
local variable 'profile' is assigned to but never used |
reviewbot
|
|
|
Hmm. Is it really worth having a separate page just for the avatar or should we fold it into the … |
david
|
|
|
avatar isn't its own page anymore, right? |
david
|
|
|
This could probably just be return list(AccountPage.registry) |
david
|
|
|
undo |
 brennie
|
|
|
undo |
brennie
|
|
|
I don't see anything in this file that uses stuff from defs? |
david
|
|
|
undo |
brennie
|
-
Tool: Pyflakes Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py reviewboard/accounts/tests.py Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/ui/boxes.less reviewboard/static/rb/css/pages/my-account.less Tool: PEP8 Style Checker Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py reviewboard/accounts/tests.py Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/ui/boxes.less reviewboard/static/rb/css/pages/my-account.less
-
Tool: PEP8 Style Checker Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py reviewboard/accounts/tests.py Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/ui/boxes.less reviewboard/static/rb/css/pages/my-account.less Tool: Pyflakes Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py reviewboard/accounts/tests.py Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/ui/boxes.less reviewboard/static/rb/css/pages/my-account.less
-
Tool: Pyflakes Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py Tool: PEP8 Style Checker Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py
Tool: Pyflakes Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py reviewboard/accounts/tests.py Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/ui/boxes.less reviewboard/static/rb/css/pages/my-account.less Tool: PEP8 Style Checker Processed Files: reviewboard/avatars/tests.py reviewboard/accounts/views.py reviewboard/accounts/pages.py reviewboard/avatars/settings.py reviewboard/avatars/registry.py reviewboard/accounts/models.py reviewboard/avatars/templatetags/avatars.py reviewboard/accounts/tests.py Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/ui/boxes.less reviewboard/static/rb/css/pages/my-account.less