Summary

Add convenience methods to the avatar registry

Review Request #8203 — Created May 31, 2016 and submitted June 1, 2016, 12:50 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The avatar services registry now provides a convenience method to lookup
an avatar service directly by its avatar service ID (as that is all that
is used), as well as a method to get either the requested service or the
default.

In addition, the get_defaults() method has been refactored to reference
a list of avatar service classes on the registry itself to simplify
subclass implementation.

The enabled_services setter now also computes the sets of avatars
services to disable and enable and disables (or enables) each one
individually.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Should it be possible for this to be called with None? Should we raise a ValueError?	david	May 31, 2016, 3:50 p.m.

Tool: Pyflakes
Processed Files:
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/tests.py
    djblets/avatars/registry.py

djblets/avatars/registry.py (Diff revision 1)

Show all issues

Should it be possible for this to be called with None? Should we raise a ValueError?

brennie May 31, 2016, 3:50 p.m.
```
The method accepts None intentionally.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (37d78d0)