-
-
/trunk/reviewboard/contrib/tools/rb-site (Diff revision 2) Theoretically, shouldn't this should check the encoding on $LANG?
Inform users of missing dependencies in rb-site install.
Review Request #820 — Created April 17, 2009 and submitted
Information | |
---|---|
chipx86 | |
Review Board SVN (deprecated) | |
trunk | |
755, 756 | |
Reviewers | |
reviewboard | |
Inform users of missing dependencies in rb-site install. rb-site previously didn't check for optional or required dependencies, meaning that a user could get far into the install and then fail at installation time due to the memcached or database modules not being available. This change adds a page after the Introduction page that will list the missing dependencies, giving users a chance to bail and install them. If they're missing support for databases altogether, then we force them to quit.
Went through both console and GTK+ installs and tested that missing dependencies were listed and that the corresponding entries weren't enabled in the UIs. Simulated not having any required DB modules and verified that I wasn't allowed to continue with the install process.
EH
-
The rb-site script is no longer working for console input.
-
/trunk/reviewboard/contrib/tools/rb-site (Diff revision 2) In the case where choice is a tuple of (text, enabled), this does not work below when checking if it is in the valid choice list. I think this should be valid_choices.append(text)
-
/trunk/reviewboard/contrib/tools/rb-site (Diff revision 2) The variable valid_choice does not exist. I think this is supposed to be "choice".