Summary

Split scmtools/tests.py into individual unit test files.

Review Request #8196 — Created May 29, 2016 and submitted Aug. 22, 2016, 3:49 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

e93a5d8...

Reviewers

Groups

reviewboard

People

Description

The SCM unit test suite was getting large, and with some upcoming work
for repository form changes, it was going to get bigger and harder to
work with.

This splits up the test suite into smaller files, one per SCMTool or
area of responsibility.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
Unnecessary blank line	brennie	Aug. 18, 2016, 1:28 p.m.
Unnecessary blank line	brennie	Aug. 18, 2016, 1:28 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:29 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:29 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:29 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:29 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:29 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:29 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:30 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:30 p.m.
This string can be entirely single quotes.	brennie	Aug. 18, 2016, 1:31 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:31 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:31 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:31 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:31 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes	brennie	Aug. 18, 2016, 1:33 p.m.
Remove this	brennie	Aug. 18, 2016, 1:33 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:35 p.m.
Remove this	brennie	Aug. 18, 2016, 1:35 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:35 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes	brennie	Aug. 18, 2016, 1:36 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Single quotes.	brennie	Aug. 18, 2016, 1:38 p.m.
Docstring?	brennie	Aug. 18, 2016, 1:39 p.m.
Docstring?	brennie	Aug. 18, 2016, 1:43 p.m.
Docstring?	brennie	Aug. 18, 2016, 1:43 p.m.
Args/returns?	brennie	Aug. 18, 2016, 1:43 p.m.

These are mostly nit-picky things, but since we're splitting this up into new files we may aswell use our new style guidelines.

chipx86 July 18, 2016, 3:44 p.m.

I'm going to go ahead and take care of all code cleanup changes in a separate change. The reason is that it's going to be a painful merge from 2.0 -> 2.5 -> 3.0 -> master, and I'll probably have to copy/paste tests from the tests.py in each branch back over these individual tests, losing fixes made here. If I do it in a separate change, they'll merge nicely.

reviewboard/scmtools/tests/test_core.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Unnecessary blank line
```
reviewboard/scmtools/tests/test_core.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Unnecessary blank line
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This string can be entirely single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove this
```

reviewboard/scmtools/tests/test_git.py (Diff revision 1)

The issue has been resolved. Show all issues

Single quotes.

reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove this
```

reviewboard/scmtools/tests/test_git.py (Diff revision 1)

The issue has been resolved. Show all issues

Single quotes.

reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```

reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)

The issue has been resolved. Show all issues

Single quotes

reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes.
```
reviewboard/scmtools/tests/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/scmtools/tests/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/scmtools/tests/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/scmtools/tests/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Args/returns?
```

Change Summary:

Updated to meet the current coding styles.

That particular commit will be landed separately from the split, in order to help with merges (as each branch's copies of these files will need to be manually updated, and landing the coding style fixes after the fact will be easier).

Commit:

+	e93a5d8f23994c44df850e06e8444a8732cc1109

Diff:

Revision 2 (+4038 -3878)

Show changes

	reviewboard/scmtools/tests.py
	reviewboard/scmtools/tests/__init__.py
	reviewboard/scmtools/tests/test_bazaar.py
	reviewboard/scmtools/tests/test_core.py
	reviewboard/scmtools/tests/test_cvs.py
	reviewboard/scmtools/tests/test_git.py
	reviewboard/scmtools/tests/test_hg.py
	reviewboard/scmtools/tests/test_perforce.py
	5 more

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (c32ad92)