Split scmtools/tests.py into individual unit test files.

Review Request #8196 — Created May 29, 2016 and submitted

Information

Review Board
release-2.0.x
e93a5d8...

Reviewers

The SCM unit test suite was getting large, and with some upcoming work
for repository form changes, it was going to get bigger and harder to
work with.

This splits up the test suite into smaller files, one per SCMTool or
area of responsibility.

Unit tests pass.

Description From Last Updated

Unnecessary blank line

brenniebrennie

Unnecessary blank line

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

This string can be entirely single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes

brenniebrennie

Single quotes

brenniebrennie

Remove this

brenniebrennie

Single quotes.

brenniebrennie

Remove this

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes

brenniebrennie

Single quotes

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Single quotes.

brenniebrennie

Docstring?

brenniebrennie

Docstring?

brenniebrennie

Docstring?

brenniebrennie

Args/returns?

brenniebrennie
brennie
  1. These are mostly nit-picky things, but since we're splitting this up into new files we may aswell use our new style guidelines.

    1. I'm going to go ahead and take care of all code cleanup changes in a separate change. The reason is that it's going to be a painful merge from 2.0 -> 2.5 -> 3.0 -> master, and I'll probably have to copy/paste tests from the tests.py in each branch back over these individual tests, losing fixes made here. If I do it in a separate change, they'll merge nicely.

  2. reviewboard/scmtools/tests/test_core.py (Diff revision 1)
     
     
    Show all issues

    Unnecessary blank line

  3. reviewboard/scmtools/tests/test_core.py (Diff revision 1)
     
     
    Show all issues

    Unnecessary blank line

  4. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  5. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  6. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  7. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  8. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  9. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  10. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  11. reviewboard/scmtools/tests/test_cvs.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  12. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    This string can be entirely single quotes.

  13. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  14. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  15. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  16. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  17. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  18. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  19. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  20. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  21. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  22. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  23. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
     
    Show all issues

    Single quotes.

  24. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  25. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  26. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  27. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  28. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  29. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  30. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  31. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  32. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  33. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  34. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  35. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  36. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  37. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes

  38. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Single quotes

  39. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Remove this

  40. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Single quotes.

  41. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
    Show all issues

    Remove this

  42. reviewboard/scmtools/tests/test_git.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Single quotes.

  43. Show all issues

    Single quotes.

  44. Show all issues

    Single quotes.

  45. reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  46. reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  47. Show all issues

    Single quotes.

  48. reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
     
     
     
    Show all issues

    Single quotes.

  49. reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
    Show all issues

    Single quotes

  50. Show all issues

    Single quotes

  51. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  52. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  53. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  54. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  55. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  56. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  57. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  58. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  59. reviewboard/scmtools/tests/test_svn.py (Diff revision 1)
     
     
    Show all issues

    Single quotes.

  60. reviewboard/scmtools/tests/testcases.py (Diff revision 1)
     
     
    Show all issues

    Docstring?

  61. reviewboard/scmtools/tests/testcases.py (Diff revision 1)
     
     
    Show all issues

    Docstring?

  62. reviewboard/scmtools/tests/testcases.py (Diff revision 1)
     
     
    Show all issues

    Docstring?

  63. reviewboard/scmtools/tests/testcases.py (Diff revision 1)
     
     
    Show all issues

    Args/returns?

  64. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (c32ad92)